General Category > Yate users hangout place

CDRBuild - Holdtime Modification - 6.0.1

<< < (2/3) > >>

ganapathi:
Hi

unable to use svn patch due to that ,Attached git patch.

I hope it's should be same as i guess.

marian:
You may want to change:
if (String(operation) == YSTRING("update") && !s_cdrUpdates && String(m_status) == YSTRING("hold") && String(m_status) == YSTRING("unhold"))
to
if (String(operation) == YSTRING("update") && !s_cdrUpdates && m_status != YSTRING("hold") && m_status != YSTRING("unhold"))

I suppose you want not to return for status=hold/unhold

You may also want to handle call termination while on hold: the 'unhold' status won't be received!

ganapathi:
Ooh. i forgot that scenario.

So am planning to put condition for that, Finalize operation is the correct option to identify the call is terminated in emit function.?

With that Modified the condition. As i hope it would match those necessary condition properly.

marian:
I think you should test it.

A suggestion:
m_unhold = Time::msecNow();
if(m_holdsec)
    m_holdsec = m_holdsec + m_unhold - m_hold;
else
    m_holdsec = m_unhold - m_hold;

may just be (simpler, you don't need an extra variable):
m_holdsec += Time::msecNow() - m_hold;

Question: m_holdsec is in seconds? if so, use Time::secNow() instead of Time::msecNow()

ganapathi:
Thanks .

Will modify as you suggested.That would save some. At initial stage it was used to check some more condition and validation.

Update you the status once tested.

Navigation

[0] Message Index

[#] Next page

[*] Previous page